Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21992 to 7.x: Fix diskio and memory bugs under windows #21999

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Cherry-pick #21992 to 7.x: Fix diskio and memory bugs under windows #21999

merged 1 commit into from
Oct 20, 2020

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 19, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21992 to 7.x branch. Original message:

What does this PR do?

Fixes some Windows bugs found under testing. We need to only call CalcIOStatistics under linux, and memory.share should be removed outside of agent, since it's a "null zero" metric under windows.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • pull down and build on Windows
  • On windows, make sure system/diskio works, and system.process.memory.share does not work.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 19, 2020
@fearful-symmetry fearful-symmetry requested a review from a team October 19, 2020 20:28
@fearful-symmetry fearful-symmetry self-assigned this Oct 19, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21999 opened]

  • Start Time: 2020-10-19T20:29:23.595+0000

  • Duration: 102 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 2244
Skipped 506
Total 2750

@fearful-symmetry fearful-symmetry merged commit 87dc4fe into elastic:7.x Oct 20, 2020
@zube zube bot removed the [zube]: Done label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fearful-symmetry @elasticmachine @kaiyan-sheng